Remove source location in server.log
#520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we save the log in
![image](https://private-user-images.githubusercontent.com/88959106/401001952-ba20beed-cc35-4651-aa54-f67cc39e39e7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMDMxMTYsIm5iZiI6MTczOTIwMjgxNiwicGF0aCI6Ii84ODk1OTEwNi80MDEwMDE5NTItYmEyMGJlZWQtY2MzNS00NjUxLWFhNTQtZjY3Y2MzOWUzOWU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE1NTMzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY1ZjYzZDhiYWRmYTMxYWZhNDQxMTAzNmQ5YTkyMTBmMGI5NzZkZmEyNGU0MTliZWZhMjAwMTMyZWI5Mjk3YTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FcGLfTD_T5u7ZEfQbmYAOvsbGciIpKDNvaiB6XRFI64)
server.log
with redundant source location, e.g. just repeatedsyftbox.server.middleware:dispatch:14
like in the picture belowThis is not useful since we print out logs from
middleware.py
and this linesyftbox.server.middleware:dispatch:14
is almost always repeated, which pollute the log infoThis PR removes that information and makes the logs in![image](https://private-user-images.githubusercontent.com/88959106/401002325-bf4e49c6-d16b-45f7-84df-5cd86c2fc70f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMDMxMTYsIm5iZiI6MTczOTIwMjgxNiwicGF0aCI6Ii84ODk1OTEwNi80MDEwMDIzMjUtYmY0ZTQ5YzYtZDE2Yi00NWY3LTg0ZGYtNWNkODZjMmZjNzBmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE1NTMzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFmNmI5YTc4ZGZlNDUxNGNjNGM1YmRlM2NmMWQzODc1OWNhNmE5NWQzMDk1NWY4YTYzY2M3NDk2MDJlZWNjMmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mzGNvc3wovmaKoAjI1XYIl4Auy-PD-HN5L2jXyhpd-8)
server.log
same with the ones printed out on the console, which isThis is good for our telemetry logs: This
![image](https://private-user-images.githubusercontent.com/88959106/401002699-ce133d97-3e63-4766-8690-706d6585cfd2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMDMxMTYsIm5iZiI6MTczOTIwMjgxNiwicGF0aCI6Ii84ODk1OTEwNi80MDEwMDI2OTktY2UxMzNkOTctM2U2My00NzY2LTg2OTAtNzA2ZDY1ODVjZmQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE1NTMzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVkYjM5MDViMTg3MjNmNjQxNmFkNGI2Zjc1YTZlYzg5M2MyNzYyZmU2NjA1ZTlhYzhmZmFhNTg3M2EwYjU0N2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9GZ6D-HDe4v52u70CwKU0JwBd28gVIc8EfYywaqm-a0)
instead of this:
![image](https://private-user-images.githubusercontent.com/88959106/401002785-c8ac7a63-1f2b-4cd0-b2f8-d6a3f47bc6f9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMDMxMTYsIm5iZiI6MTczOTIwMjgxNiwicGF0aCI6Ii84ODk1OTEwNi80MDEwMDI3ODUtYzhhYzdhNjMtMWYyYi00Y2QwLWIyZjgtZDZhM2Y0N2JjNmY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE1NTMzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVjMjVhNmZjMDM0MGE3MjliMTBmMjYxMjA1YmIxZTBkOTgxNmY1YmFlNGY2MWEzZjFhNmY2MjA3MGMxNjVlMDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.96TLfLGwCFED21A0EpB6H4RLkK0tUigH5foPgjKn8jI)