Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source location in server.log #520

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

khoaguin
Copy link
Member

@khoaguin khoaguin commented Jan 8, 2025

Currently we save the log in server.log with redundant source location, e.g. just repeated syftbox.server.middleware:dispatch:14 like in the picture below
image

This is not useful since we print out logs from middleware.py and this line syftbox.server.middleware:dispatch:14 is almost always repeated, which pollute the log info

This PR removes that information and makes the logs in server.log same with the ones printed out on the console, which is image

This is good for our telemetry logs: This
image

instead of this:
image

… printed out in the consol (specified in middleware.py)
@khoaguin khoaguin changed the title add custom log format when saving to log file to match the the format… Remove source location in server.log Jan 8, 2025
@teo-milea teo-milea merged commit df15dd8 into main Jan 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants