docs: contributing

[danielorihuela]

Description

Copied and modified the contributing documentation from PySyft.
Explains how to install and test SyMPC.

Closes #58

Checklist

• I have followed the Contribution Guidelines and Code of Conduct

[aanurraj]

Looks good, I requested few changes you might need to do that. Also, have you checked all the steps if they are working correctly?

[danielorihuela]

Looks good, I requested few changes you might need to do that. Also, have you checked all the steps if they are working correctly?

I checked all except the windows and macos parts, I only have a linux computer.
Also, there is a problem with the requirements.txt and requirements.dev.txt when you try to install them. But I guess that is due to the transformation of pysyft main repo to a monorepo.

[gmuraru]

Looks good, I requested few changes you might need to do that. Also, have you checked all the steps if they are working correctly?

I checked all except the windows and macos parts, I only have a linux computer.
Also, there is a problem with the requirements.txt and requirements.dev.txt when you try to install them. But I guess that is due to the transformation of pysyft main repo to a monorepo.

It should work now.

[gmuraru]

I will give tomorrow another look - but added some comments

[gmuraru]

LGTM!

[gmuraru]

Only solve the conflict and I think this is good to go 🚀

[danielorihuela]

All tests passed but is waiting for python-tests (3.8). Is that a bug?

[gmuraru]

All tests passed but is waiting for python-tests (3.8). Is that a bug?

I updated the branch. I am not sure...I have seen it hold up one other time - let's see them now

[gmuraru]

I will force squash and merge this after the tests are passing

[danielorihuela]

I will force squash and merge this after the tests are passing

As you wish, but I would not like that this behaviour gets expanded to all PRs. Are you sure this will disappear?

It is curious, I have done a run in my fork and that bug does not happen.
danielorihuela#13 (comment)

[gmuraru]

Asked @aanurraj to look again over this - I think it is good to go, but it is better to have another pair of eyes to look over this 👀

[gmuraru]

I will force squash and merge this after the tests are passing

As you wish, but I would not like that this behaviour gets expanded to all PRs. Are you sure this will disappear?

It is curious, I have done a run in my fork and that bug does not happen.
danielorihuela#13 (comment)

Yeah...we should keep an eye on this problem...and if this happens once more, we should investigate this.