Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement QuantileTree.Merge method #433

Merged
merged 4 commits into from
Oct 29, 2022
Merged

Implement QuantileTree.Merge method #433

merged 4 commits into from
Oct 29, 2022

Conversation

dvadym
Copy link
Collaborator

@dvadym dvadym commented Oct 21, 2022

QuantileTree.Merge should return Summary as all other PyDP objects, but in the 1st implementation it returned dp::BoundedQuantilesSummary. This PR fixes that.

Along a way, some minor stuff fixed as well.
1.max_partitions_contributed_to->max_partitions_contributed
2. Fixed a text of one exception.

chinmayshah99
chinmayshah99 reviewed Oct 21, 2022
View reviewed changes
Copy link
Member

@chinmayshah99 chinmayshah99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just wanted to confirm if max_partitions_contributed_to is not used anywhere in the example?

@dvadym
Copy link
Collaborator Author

dvadym commented Oct 21, 2022

I've checked, max_partitions_contributed_to it's not used in examples. I've replaced it in all places in QuantileTree code.

@chinmayshah99 chinmayshah99 merged commit ab98495 into OpenMined:dev Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmayshah99 chinmayshah99 chinmayshah99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvadym @chinmayshah99