Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re enable Fortran optimization flag on windows #743

Merged
merged 1 commit into from
Feb 2, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jan 18, 2016

partial revert of 299cdcd
from #696, was not explained why that was needed cc @wernsaar

@xianyi
Copy link
Collaborator

xianyi commented Jan 26, 2016

@tkelman , did you run lapack test on windows?

@tkelman
Copy link
Contributor Author

tkelman commented Jan 29, 2016

Not yet. I'll try to remember to do that when I have a moment. Keep reminding me every few days until I do.

partial revert of OpenMathLib@299cdcd
from OpenMathLib#696, was not explained why that was needed
@tkelman
Copy link
Contributor Author

tkelman commented Jan 30, 2016

I couldn't figure out how to run lapack's tests directly, but all of Julia's tests pass on an i7-6700HQ, windows 64 bit build of openblas commit 5fef0d1

@martin-frbg
Copy link
Collaborator

"make lapack-test" probably, or are you using an IDE rather than a plain makefile environment ?

@tkelman
Copy link
Contributor Author

tkelman commented Jan 31, 2016

using makefiles, but with the build configuration customized as julia needs. I'm also cross compiling from cygwin which the test scripts might not be written in a way that can handle, but I'll give it a try.

@tkelman
Copy link
Contributor Author

tkelman commented Jan 31, 2016

                        -->   LAPACK TESTING SUMMARY  <--
SUMMARY                 nb test run     numerical error         other error
================        ===========     =================       ================
REAL                    1169109         0       (0.000%)        0       (0.000%)
DOUBLE PRECISION        1169921         0       (0.000%)        0       (0.000%)
COMPLEX                 633152          0       (0.000%)        0       (0.000%)
COMPLEX16               633964          0       (0.000%)        0       (0.000%)

--> ALL PRECISIONS      3606146         0       (0.000%)        0       (0.000%)

xianyi added a commit that referenced this pull request Feb 2, 2016
re enable Fortran optimization flag on windows
@xianyi xianyi merged commit 9f080c4 into OpenMathLib:develop Feb 2, 2016
@tkelman tkelman deleted the patch-1 branch February 2, 2016 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants