Process only required attributes in api/rest/products/

[sreichel]

Description (*)

Using REST api like https://magento-lts.ddev.site/api/rest/products/ace000 loads all product attributes, even if they are not selected in admin REST attributes configuration. Urls are genenated, prices are loaded, ...

[sreichel]

before (blue = useless calls when no prices or urls are required)

after

[theroch]

Please add some more php doc comments.
The actual code logic looks OK to me.

[Hanmac]

@sreichel why did this MR get closed?

[sreichel]

Too lazy to add docblocks.

(i cant remember aany new method added, where someone requested docblock changes)

[sreichel]

• tests should be fixed in Updated SonarQube action #4489
• @theroch i dont know what to change for your request

[Hanmac]

@theroch i dont know what to change for your request

@sreichel i talked with him, his concern was that addAttribute only has effect for specific attributes

but for each other, the attribute should already be in productData

or should we add a $productData[$attribute] = $product->getData($attribute) default for the switch/case?

[sreichel]

or should we add a $productData[$attribute] = $product->getData($attribute) default for the switch/case?

Or return; (void) as default ... PR?

[Hanmac]

this MR is ready to merge i think, why is it getting closed again?

[sreichel]

Cant merge b/c of the change request ....

[sreichel]

@theroch 2 weeks w/o response ....

Thanks for blocking this.

[sreichel]

Closed again.

https://github.com/sponsors/sreichel .... thanks in advance.

[Hanmac]

@sreichel
@theroch is currently on vacation til March

[Hanmac]

@theroch 2 weeks w/o response ....

Thanks for blocking this.

And if you want to be pedantic, there are some cases where it needed to wait a bit longer:
#4511 did also take 2 weeks until it got merged
#4008 took from May 2024 til Oct 2024 until it got merged

[sreichel]

Its not about the time to get a PR merged, but if you block a PR (request changes) you should reply in time. imho

[sreichel]

And if you want to be pedantic, there are some cases where it needed to wait a bit longer:
#4511 did also take 2 weeks until it got merged
#4008 took from May 2024 til Oct 2024 until it got merged

Difference ... you get paid for your PRs - regardless how long it takes to merge - ....

[kiatng]

@Hanmac Thanks for communicating with @theroch and explain why he's not responding.

It's not right to block a PR when @sreichel has put in the effort without timely response. It can be frustrating.

I will reopen the PR and address any pending changes when @theroch returns in March. I hope @sreichel is OK with this.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud