Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Check for DS / PS already set #4484

Merged
merged 9 commits into from
Feb 21, 2025
Merged

Chore: Check for DS / PS already set #4484

merged 9 commits into from
Feb 21, 2025

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 15, 2025 •
edited
Loading

Description (*)

@justinbeaty, only to remove some changes from #4411, to make review easier.

@sreichel sreichel added the chore label Jan 15, 2025
@github-actions github-actions bot added the Mage.php Relates to app/Mage.php label Jan 15, 2025
@github-actions github-actions bot added Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales labels Jan 15, 2025
@sreichel sreichel modified the milestones: 20.13.0, 20.14.0 Jan 17, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sreichel sreichel merged commit cf16ac8 into OpenMage:main Feb 21, 2025
19 checks passed
fballiano added a commit to MahoCommerce/maho that referenced this pull request Feb 22, 2025
@fballiano
OM PR 4484
36d075d 
OpenMage/magento-lts#4484
fballiano added a commit to MahoCommerce/maho that referenced this pull request Feb 22, 2025
@fballiano
OM PR 4484
7a7712a 
OpenMage/magento-lts#4484
fballiano added a commit to MahoCommerce/maho that referenced this pull request Feb 22, 2025
@fballiano
OM PR 4484
03d0f57 
OpenMage/magento-lts#4484
fballiano added a commit to MahoCommerce/maho that referenced this pull request Feb 22, 2025
@fballiano
OM PR 4484
e3d6d79 
OpenMage/magento-lts#4484
@sreichel sreichel deleted the define-ds-bp branch February 23, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano left review comments

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
chore Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Mage.php Relates to app/Mage.php phpstan
Projects
None yet
Milestone
20.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @colinmollenhour @fballiano @kiatng