Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type casting and minor fixes in preparation for declare strict_types=1 #3648

Merged
merged 15 commits into from
May 6, 2024
Merged

Type casting and minor fixes in preparation for declare strict_types=1 #3648

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
cbe2ebd
Crash test for declare strict_types
luigifab Nov 12, 2023
c504166
Allow to save product
luigifab Nov 12, 2023
067a2ee
Show file on error
luigifab Nov 12, 2023
f561888
Merge branch 'main' into strict1
fballiano Feb 6, 2024
907d672
Removed all getIsDeveloperMode related code
fballiano Feb 7, 2024
c1a6a11
Merge branch 'main' into strict1
fballiano Feb 7, 2024
6cf082e
Update app/code/core/Mage/Customer/Model/Address/Config.php
fballiano Feb 28, 2024
12fe5d1
typo
fballiano Apr 19, 2024
bbfac43
Merge branch 'main' into strict1
fballiano Apr 19, 2024
25482ea
Update app/code/core/Mage/Core/Model/Layout.php
fballiano Apr 26, 2024
4863470
removed modification that should not be part of this PR
fballiano Apr 26, 2024
f02a72b
Kiat suggestions, plus str_contains
fballiano Apr 26, 2024
415300e
Merge branch 'main' into strict1
fballiano Apr 26, 2024
5ed2482
Merge branch 'main' into strict1
fballiano May 2, 2024
080965c
reverted change for further discussion
fballiano May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/core/Mage/Customer/Model/Address/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
$type = new Varien_Object();
$htmlEscape = strtolower((string)$typeConfig->htmlEscape);
$htmlEscape = !($htmlEscape == 'false' || $htmlEscape == '0' || $htmlEscape == 'no'
|| !strlen((string)$typeConfig->htmlEscape));
|| !strlen($htmlEscape);

Check failure on line 104 in app/code/core/Mage/Customer/Model/Address/Config.php

View workflow job for this annotation

GitHub Actions / PHPStan / Analyze (ubuntu-latest, 8.3) 

Syntax error, unexpected ';' on line 104
fballiano marked this conversation as resolved.
Show resolved Hide resolved
$type->setCode($typeCode)
->setTitle((string)$typeConfig->title)
->setDefaultFormat(Mage::getStoreConfig($path, $store))
Expand Down
Loading