Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PHPCS github workflow for unexisting ruleset #3500

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Fixed PHPCS github workflow for unexisting ruleset #3500

merged 1 commit into from
Sep 8, 2023

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 7, 2023

With last change all errors are ignored.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

With last change all errors are ignored.
@sreichel sreichel changed the title Fixes phpcs.yml Fixes phpcs github action Sep 7, 2023
@kiatng
Copy link
Contributor

kiatng commented Sep 8, 2023

I asked ChatGPT for help, it says:

In summary, the difference between these two statements lies in the specific ruleset files they are checking for. The first statement continues on error for files using a ruleset other than .github/phpcs-ruleset.xml, while the second statement continues on error for files using a ruleset other than .phpcs.xml.dist. ...

there is no such file .github/phpcs-ruleset.xml

@fballiano fballiano changed the title Fixes phpcs github action Fixed PHPCS github workflow for unexisting ruleset Sep 8, 2023
@fballiano fballiano merged commit ccbaa15 into OpenMage:main Sep 8, 2023
13 of 15 checks passed
@sreichel sreichel deleted the patch-1 branch September 8, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants