Revert change of loading modules into config. #3423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bugs it causes can vary. For me, the search bar did not load because it wanted to load into a header that did not exist yet.
|
can you please provide some more info? |
nevermind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The bugs it causes can vary. For me, the search bar did not load because it wanted to load into a header that did not exist yet.
After ±12h of debugging I found a problematic commit that affected the order of loaded modules (including layouts), and because of this my 'topSearch' trying to be child of 'header' which did not exist yet(because order of loading layout files was changed)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)