Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed passing null for unserialize is deprecated in Mage_Sales_Model_Quote_Address #3337

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

kyrena
Copy link
Contributor

@kyrena kyrena commented Jun 20, 2023

Description

This fix passing null to parameter #1 ($string) of type string is deprecated for unserialize with PHP 8.1/8.2.
Perhaps it's not the best way. Not sure if it's due to a third party code or not.

See also this discussion comment.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Jun 20, 2023
@fballiano fballiano merged commit bda0b6f into OpenMage:main Jun 20, 2023
15 checks passed
@kyrena kyrena deleted the php82-tax branch June 20, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Relates to Mage_Sales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants