Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed undefined constant in installer #3259

Merged
merged 2 commits into from
May 15, 2023
Merged

Fixed undefined constant in installer #3259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84a0ac1
Fixed undefined constant
sreichel May 15, 2023
ae76360
Update phpstan.dist.baseline.neon
fballiano May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/core/Mage/Install/Model/Installer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ public function createAdministrator($data)
//to support old logic checking if real data was passed
if (is_array($data)) {
$data = $this->validateAndPrepareAdministrator($data);
if (is_array(data)) {
if (is_array($data)) {
throw new Exception(Mage::helper('install')->__('Please correct the user data and try again.'));
}
}
Expand Down
5 changes: 0 additions & 5 deletions phpstan.dist.baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3220,11 +3220,6 @@ parameters:
count: 1
path: app/code/core/Mage/Install/Model/Config.php

-
message: "#^Constant data not found\\.$#"
count: 1
path: app/code/core/Mage/Install/Model/Installer.php

-
message: "#^Method Mage_Install_Model_Installer\\:\\:getDataModel\\(\\) should return Mage_Install_Model_Session but returns Mage_Install_Model_Installer_Data\\|null\\.$#"
count: 1
Expand Down