Use short array syntax

app/code/core/Mage/Admin/Model/Acl/Role/Registry.php

@@ -49,7 +49,7 @@ public function addParent($role, $parents)
         }
 
         if (!is_array($parents)) {
-            $parents = array($parents);
+            $parents = [$parents];
         }
         foreach ($parents as $parent) {
             try {

app/code/core/Mage/Admin/Model/Block.php

@@ -49,7 +49,7 @@ protected function _construct()
      */
     public function validate()
     {
-        $errors = array();
+        $errors = [];
 
         if (!Zend_Validate::is($this->getBlockName(), 'NotEmpty')) {
             $errors[] = Mage::helper('adminhtml')->__('Block Name is required field.');
@@ -58,11 +58,11 @@ public function validate()
         if (in_array($this->getBlockName(), $disallowedBlockNames)) {
             $errors[] = Mage::helper('adminhtml')->__('Block Name is disallowed.');
         }
-        if (!Zend_Validate::is($this->getBlockName(), 'Regex', array('/^[-_a-zA-Z0-9]+\/[-_a-zA-Z0-9\/]+$/'))) {
+        if (!Zend_Validate::is($this->getBlockName(), 'Regex', ['/^[-_a-zA-Z0-9]+\/[-_a-zA-Z0-9\/]+$/'])) {
             $errors[] = Mage::helper('adminhtml')->__('Block Name is incorrect.');
         }
 
-        if (!in_array($this->getIsAllowed(), array('0', '1'))) {
+        if (!in_array($this->getIsAllowed(), ['0', '1'])) {
             $errors[] = Mage::helper('adminhtml')->__('Is Allowed is required field.');
         }
 

app/code/core/Mage/Admin/Model/Config.php

@@ -70,7 +70,7 @@ public function __construct()
                 Mage::app()->saveCache(
                     $adminhtmlConfig->getXmlString(),
                     $this->getCacheId(),
-                    array(Mage_Core_Model_Config::CACHE_TAG)
+                    [Mage_Core_Model_Config::CACHE_TAG]
                 );
             }
         }

app/code/core/Mage/Admin/Model/Observer.php

@@ -43,13 +43,13 @@ public function actionPreDispatchAdmin($observer)
         $user = $session->getUser();
 
         $requestedActionName = strtolower($request->getActionName());
-        $openActions = array(
+        $openActions = [
             'forgotpassword',
             'resetpassword',
             'resetpasswordpost',
             'logout',
             'refresh' // captcha refresh
-        );
+        ];
         if (in_array($requestedActionName, $openActions)) {
             $request->setDispatched(true);
         } else {

app/code/core/Mage/Admin/Model/Redirectpolicy.php

@@ -35,7 +35,7 @@ class Mage_Admin_Model_Redirectpolicy
     /**
      * @param array $parameters array('urlModel' => object)
      */
-    public function __construct($parameters = array())
+    public function __construct($parameters = [])
     {
         $this->_urlModel = (!empty($parameters['urlModel'])) ?
             $parameters['urlModel'] : Mage::getModel('adminhtml/url');

app/code/core/Mage/Admin/Model/Resource/Acl.php

@@ -65,11 +65,11 @@ public function loadAcl()
         $this->loadRoles($acl, $rolesArr);
 
         $select = $adapter->select()
-            ->from(array('r' => $ruleTable))
+            ->from(['r' => $ruleTable])
             ->joinLeft(
-                array('a' => $assertTable),
+                ['a' => $assertTable],
                 'a.assert_id = r.assert_id',
-                array('assert_type', 'assert_data')
+                ['assert_type', 'assert_data']
             );
 
         $rulesArr = $adapter->fetchAll($select);

app/code/core/Mage/Admin/Model/Resource/Block.php

@@ -37,7 +37,7 @@ class Mage_Admin_Model_Resource_Block extends Mage_Core_Model_Resource_Db_Abstra
      *
      * @var array
      */
-    protected $disallowedBlockNames = array('install/end');
+    protected $disallowedBlockNames = ['install/end'];
 
     /**
      * Define main table
@@ -69,17 +69,17 @@ protected function _generateCache()
     {
         /** @var Mage_Admin_Model_Resource_Block_Collection $collection */
         $collection = Mage::getResourceModel('admin/block_collection');
-        $collection->addFieldToFilter('is_allowed', array('eq' => 1));
+        $collection->addFieldToFilter('is_allowed', ['eq' => 1]);
         $disallowedBlockNames = $this->getDisallowedBlockNames();
         if (is_array($disallowedBlockNames) && count($disallowedBlockNames) > 0) {
-            $collection->addFieldToFilter('block_name', array('nin' => $disallowedBlockNames));
+            $collection->addFieldToFilter('block_name', ['nin' => $disallowedBlockNames]);
         }
         $data = $collection->getColumnValues('block_name');
         $data = array_flip($data);
         Mage::app()->saveCache(
             Mage::helper('core')->jsonEncode($data),
             self::CACHE_ID,
-            array(Mage_Core_Model_App::CACHE_TAG)
+            [Mage_Core_Model_App::CACHE_TAG]
         );
     }
 

app/code/core/Mage/Admin/Model/Resource/Roles.php

@@ -72,12 +72,12 @@ protected function _beforeSave(Mage_Core_Model_Abstract $role)
 
         if ($role->getPid() > 0) {
             $select = $this->_getReadAdapter()->select()
-                ->from($this->getMainTable(), array('tree_level'))
+                ->from($this->getMainTable(), ['tree_level'])
                 ->where("{$this->getIdFieldName()} = :pid");
 
-            $binds = array(
+            $binds = [
                 'pid' => (int) $role->getPid(),
-            );
+            ];
 
             $treeLevel = $this->_getReadAdapter()->fetchOne($select, $binds);
         } else {
@@ -99,7 +99,7 @@ protected function _afterSave(Mage_Core_Model_Abstract $role)
         $this->_updateRoleUsersAcl($role);
         Mage::app()->getCache()->clean(
             Zend_Cache::CLEANING_MODE_MATCHING_TAG,
-            array(Mage_Adminhtml_Block_Page_Menu::CACHE_TAGS)
+            [Mage_Adminhtml_Block_Page_Menu::CACHE_TAGS]
         );
         return $this;
     }
@@ -116,12 +116,12 @@ protected function _afterDelete(Mage_Core_Model_Abstract $role)
 
         $adapter->delete(
             $this->getMainTable(),
-            array('parent_id = ?' => (int) $role->getId())
+            ['parent_id = ?' => (int) $role->getId()]
         );
 
         $adapter->delete(
             $this->_ruleTable,
-            array('role_id = ?' => (int) $role->getId())
+            ['role_id = ?' => (int) $role->getId()]
         );
 
         return $this;
@@ -137,13 +137,13 @@ public function getRoleUsers(Mage_Admin_Model_Roles $role)
     {
         $read = $this->_getReadAdapter();
 
-        $binds = array(
+        $binds = [
             'role_id'   => $role->getId(),
             'role_type' => 'U'
-        );
+        ];
 
         $select = $read->select()
-            ->from($this->getMainTable(), array('user_id'))
+            ->from($this->getMainTable(), ['user_id'])
             ->where('parent_id = :role_id')
             ->where('role_type = :role_type')
             ->where('user_id > 0');
@@ -164,8 +164,8 @@ private function _updateRoleUsersAcl(Mage_Admin_Model_Roles $role)
         $rowsCount = 0;
 
         if (count($users)) {
-            $bind  = array('reload_acl_flag' => 1);
-            $where = array('user_id IN(?)' => $users);
+            $bind  = ['reload_acl_flag' => 1];
+            $where = ['user_id IN(?)' => $users];
             $rowsCount = $write->update($this->_usersTable, $bind, $where);
         }
 

app/code/core/Mage/Admin/Model/Resource/Rules.php

@@ -49,25 +49,25 @@ public function saveRel(Mage_Admin_Model_Rules $rule)
             $adapter->beginTransaction();
             $roleId = $rule->getRoleId();
 
-            $condition = array(
+            $condition = [
                 'role_id = ?' => (int) $roleId,
-            );
+            ];
 
             $adapter->delete($this->getMainTable(), $condition);
 
             $postedResources = $rule->getResources();
             if ($postedResources) {
-                $row = array(
+                $row = [
                     'role_type'   => 'G',
                     'resource_id' => 'all',
                     'privileges'  => '', // not used yet
                     'assert_id'   => 0,
                     'role_id'     => $roleId,
                     'permission'  => 'allow'
-                );
+                ];
 
                 // If all was selected save it only and nothing else.
-                if ($postedResources === array('all')) {
+                if ($postedResources === ['all']) {
                     $insertData = $this->_prepareDataForTable(new Varien_Object($row), $this->getMainTable());
 
                     $adapter->insert($this->getMainTable(), $insertData);

app/code/core/Mage/Admin/Model/Resource/Rules/Collection.php

@@ -71,7 +71,7 @@ public function addSortByLength()
      */
     public function getResourcesPermissionsArray()
     {
-        $resourcesPermissionsArray = array();
+        $resourcesPermissionsArray = [];
         foreach ($this as $item) {
             $resourcesPermissionsArray[$item->getResourceId()] = $item->getPermission();
         }