Removed load of root category, fixed phpstan

OpenMage · Aug 18, 2023 · ad9d881 · ad9d881
1 parent 5f174bf
commit ad9d881
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/app/code/core/Mage/GoogleAnalytics/Helper/Data.php b/app/code/core/Mage/GoogleAnalytics/Helper/Data.php
@@ -172,23 +172,19 @@ public function isUserIdEnabled($store = null)
      * Returns last category name
      *
      * @param Mage_Catalog_Model_Product $product
-     * @return ?string
+     * @return string
      */
     public function getLastCategoryName($product): string
     {
-        // force root category to current store
-        $rootCategory = Mage::getModel('catalog/category')
-            ->load(Mage::app()->getStore()->getRootCategoryId());
-
-        $_lastCat = Mage::getResourceModel('catalog/category_collection')
+        $storeRootCategory = Mage::app()->getStore()->getRootCategoryId();
+        $lastCategory = Mage::getResourceModel('catalog/category_collection')
             ->addAttributeToSelect('name')
             ->addIdFilter($product->getCategoryIds())
             ->addIsActiveFilter()
-            ->addFieldToFilter('path', array('like' => $rootCategory->getPath() . '/%'))
+            ->addFieldToFilter('path', ['like' => "{$storeRootCategory}/%"])
             ->addOrder('level')
             ->getFirstItem();
-
-        return $_lastCat->getName() ?: false;
+        return $lastCategory->getName() ?: '';
     }
 
     /**