Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builds for deprecated CentOS 7 #56

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Update builds for deprecated CentOS 7 #56

merged 1 commit into from
Jan 15, 2025

Conversation

velomatt
Copy link
Contributor

  • Update README with yum workaround
  • Update dockerfiles to apply workaround

@velomatt velomatt requested a review from a team as a code owner January 10, 2025 20:58
@velomatt velomatt requested review from snubatreus and iso-p January 10, 2025 20:59
iso-p
iso-p reviewed Jan 10, 2025
View reviewed changes
Copy link

@iso-p iso-p left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me if the failed submodules' pipelines are also fixed with the docker file changes.

update: Since Matt tested the docker build and also non-docker build, so this should not be an issue.

@velomatt velomatt force-pushed the fix-deprecated-centos-yum-repos branch from 98a0196 to c7f111e Compare January 11, 2025 00:08
@velomatt
Update builds for deprecated CentOS 7
37210ec 
- Update README with yum workaround
- Update dockerfiles to apply workaround
- Add missing build deps to manual build README steps
- Add explicit step to install aws-sdk-cpp to README for manual build
@velomatt velomatt force-pushed the fix-deprecated-centos-yum-repos branch from c7f111e to 37210ec Compare January 11, 2025 00:09
@velomatt velomatt requested a review from iso-p January 11, 2025 00:11
iso-p
iso-p reviewed Jan 13, 2025
View reviewed changes
README.md Show resolved Hide resolved
iso-p
iso-p reviewed Jan 13, 2025
View reviewed changes
Copy link

@iso-p iso-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my comment for the cppunit-devel package. Rest stuff looks good to me.

@velomatt velomatt merged commit edc7562 into master Jan 15, 2025
1 check passed
@velomatt velomatt deleted the fix-deprecated-centos-yum-repos branch January 15, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iso-p iso-p iso-p approved these changes

@snubatreus snubatreus Awaiting requested review from snubatreus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@velomatt @iso-p