Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI and test cleanup #788

Merged
merged 14 commits into from
Jul 27, 2022
Merged

CI and test cleanup #788

merged 14 commits into from
Jul 27, 2022

Conversation

robfalck
Copy link
Contributor

@robfalck robfalck commented Jul 23, 2022 •
edited
Loading

Summary

  • This cleans up some residual tests that were being built for the sake of generating the old documentation.
    If not needed for coverage, these tests are now omitted.
  • The --pre_announce flag from testflo has been removed to allow tests to run in parallel.
  • Removed the previously deprecated get_state_target_metadata introspection function.
  • Added test coverage of the 1976 atmosphere Akima coefficient generation script.
  • Separated the test and doc build CI tasks to reduce the CI cycle time.
  • Increased timeout duration to 240s for the documentation build since the commercial aircraft and partial coloring demos were frequently timing out.
  • Implemented pep8 fixes to the linkage report python files, but it's not clear why these were passing on CI but failing locally.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@coveralls
Copy link

coveralls commented Jul 23, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 96.356% when pulling 6e375ba on robfalck:test_and_ci_cleanup into 7e7de74 on OpenMDAO:master.

robfalck added 6 commits July 23, 2022 21:48
@robfalck
coverage improvements in atmosphere and grid refinement
91b7092
@robfalck
fixed some pep8 issues in the linkage report code. Not sure why they …
b6de0ed 
…trigger locally but not on CI.
@robfalck
removed deprecated state targets introspection function. Set IPOPT pr…
78d0714 
…int_level to 0 in docs.
@robfalck
Coveraged improvements.
e8fde58 
- Added test of ph adaptive grid refinement.
- Removed defunct get_rate_source_path method from explicit shooting transcription.
- Removed unnecessary explicit benchmark file.
- Reenabled some skipped tests.
@robfalck
remove pre announce from CI testing
2e3523a
@robfalck
Require OM 3.18.0 or greater for case prefix test.
62d5719
@robfalck robfalck changed the title [WIP] CI and test cleanup CI and test cleanup Jul 26, 2022
@robfalck robfalck requested a review from naylor-b July 27, 2022 14:36
naylor-b
naylor-b approved these changes Jul 27, 2022
View reviewed changes
dymos/test/test_run_problem.py
@@ -16,13 +17,14 @@
from openmdao.utils.general_utils import set_pyoptsparse_opt
_, optimizer = set_pyoptsparse_opt('IPOPT', fallback=True)

om_version = tuple([int(s) for s in openmdao.__version__.split('-')[0].split('.')])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it might be worthwhile to compute this tuple in openmdao.api to provide a convenient way to check openmdao version.

@robfalck robfalck merged commit 50fa38e into OpenMDAO:master Jul 27, 2022
@robfalck robfalck deleted the test_and_ci_cleanup branch August 25, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naylor-b naylor-b naylor-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the doc build a separate job on CI Cleanup of CI and defunct documentation cases.
3 participants
@robfalck @coveralls @naylor-b