Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored TimeComp to avoid unnecessary recalculation of partials #759

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Refactored TimeComp to avoid unnecessary recalculation of partials #759

merged 1 commit into from
Jun 3, 2022

Conversation

robfalck
Copy link
Contributor

@robfalck robfalck commented Jun 3, 2022

Summary

TimeComp was using compute_partials to evaluate the partials, but their values are entirely known at setup time and therefore should have their values set during declare_partials.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@robfalck
refactored TimeComp to avoid unnecessary recalculation of partials

Verified

This commit was signed with the committer’s verified signature.
Vrixyz Thierry Berger
GPG key ID: 367278AA7917D517
Verified
Learn about vigilant mode
82c10eb
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0004%) to 95.509% when pulling 82c10eb on robfalck:timecomp_efficiency into 85663d7 on OpenMDAO:master.

@robfalck robfalck merged commit 91dc2f4 into OpenMDAO:master Jun 3, 2022
@robfalck robfalck deleted the timecomp_efficiency branch August 25, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kenneth-T-Moore Kenneth-T-Moore

@swryan swryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TimeComp has an unnecessary compute_partials method.
4 participants
@robfalck @coveralls @Kenneth-T-Moore @swryan