Removed SolveIVP and removed dead code from TranscriptionBase
#1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow handled by configure_time_introspection. Remove SolveIVP which has been deprecated for some time and is no longer functional in the codebase.
swryan
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed time units introspection from
TranscriptionBase, since it's now handled by configure_time_introspection.Removed
SolveIVPwhich has been deprecated for some time and is no longer functional in the codebase.Related Issues
Backwards incompatibilities
The
SolveIVPtranscription, which had been replaced byExplicitShootingfor several releases and deprecated, is removed from the codebase.New Dependencies
None