Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC JMX metrics #13112

Merged
merged 5 commits into from
Aug 8, 2020
Merged

gRPC JMX metrics #13112

merged 5 commits into from
Aug 8, 2020

Conversation

annaguri
Copy link
Contributor

for #12940

@annaguri annaguri marked this pull request as draft July 21, 2020 13:56
@annaguri annaguri marked this pull request as ready for review August 5, 2020 22:06
@annaguri
Copy link
Contributor Author

annaguri commented Aug 5, 2020

#build

@LibbyBot
Copy link

LibbyBot commented Aug 5, 2020

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

LibbyBot commented Aug 5, 2020

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_3glVQNdfEeqBAvt2Ajbd0w

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Aug 6, 2020

The build annaguri-13112-20200805-2221
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_3glVQNdfEeqBAvt2Ajbd0w
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_3glVQNdfEeqBAvt2Ajbd0w

@LibbyBot
Copy link

LibbyBot commented Aug 6, 2020

Your Open Liberty build results are ready for viewing.

@tevans78
Copy link
Member

tevans78 commented Aug 6, 2020

Lastly, 21 commits is too many for a PR, please squash/fixup before merging. Thank you.

@annaguri annaguri force-pushed the 12940-gRPC_JMX_metrics branch 2 times, most recently from be72cab to 3d6c0cb Compare August 6, 2020 21:33
@annaguri annaguri requested a review from wtlucy August 6, 2020 21:40
@annaguri
Copy link
Contributor Author

annaguri commented Aug 6, 2020

#build

@LibbyBot
Copy link

LibbyBot commented Aug 6, 2020

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

LibbyBot commented Aug 6, 2020

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_NNcNwNglEeqBAvt2Ajbd0w

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Aug 7, 2020

Your Open Liberty build results are ready for viewing.

@LibbyBot
Copy link

LibbyBot commented Aug 7, 2020

The build annaguri-13112-20200806-2157
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_NNcNwNglEeqBAvt2Ajbd0w
completed successfully!

wtlucy
wtlucy approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@wtlucy wtlucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the recent changes, thanks!

@annaguri annaguri requested a review from donbourne August 7, 2020 13:55
@donbourne
Copy link
Member

just reviewed the list of new metrics -- looks good (dev/com.ibm.ws.microprofile.metrics.2.3.monitor/src/com/ibm/ws/microprofile/metrics/monitor/MappingTable.java)

@annaguri
Copy link
Contributor Author

annaguri commented Aug 7, 2020

#run-libby-bot

@wraschke
Copy link
Member

wraschke commented Aug 8, 2020

#run-libby

@LibbyBot
Copy link

LibbyBot commented Aug 8, 2020

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 29 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 2 infrastructure code files were changed.

  • 10 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.microprofile.metrics.2.3/resources/com/ibm/ws/microprofile/metrics/resources/Metrics.nlsprops

  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.microprofile.metrics.2.3/resources/com/ibm/ws/microprofile/metrics/resources/Metrics.nlsprops

@annaguri annaguri merged commit b0ff612 into OpenLiberty:integration Aug 8, 2020
@annaguri annaguri deleted the 12940-gRPC_JMX_metrics branch August 8, 2020 14:20
@wtlucy wtlucy mentioned this pull request Oct 8, 2020
Closed
28 tasks
@hutchig hutchig mentioned this pull request Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tevans78 tevans78 tevans78 left review comments

@wtlucy wtlucy wtlucy approved these changes

@donbourne donbourne Awaiting requested review from donbourne

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@annaguri @LibbyBot @tevans78 @donbourne @wraschke @wtlucy