Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for bootstrap properties code completion replacing existing line #306

Merged

Conversation

arunvenmany-ibm
Copy link
Contributor

No description provided.

@arunvenmany-ibm
Copy link
Contributor Author

Screen.Recording.2024-10-07.at.6.52.45.PM.mov

@arunvenmany-ibm arunvenmany-ibm linked an issue Oct 7, 2024 that may be closed by this pull request
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Just one question...why did I see a diagnostic flagged when you selected the bootstrap property com.ibm.ws.logging.console.source in the video (at 18 seconds)?

@arunvenmany-ibm
Copy link
Contributor Author

The change looks good. Just one question...why did I see a diagnostic flagged when you selected the bootstrap property com.ibm.ws.logging.console.source in the video (at 18 seconds)?

Thats because we have not set the property value. once set value for the property, diagnostic disappeared

image image

Once some value is set, diagnostic is disappeared
image

Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
@arunvenmany-ibm arunvenmany-ibm merged commit 5f3d20e into OpenLiberty:main Oct 8, 2024
4 checks passed
@arunvenmany-ibm arunvenmany-ibm linked an issue Oct 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion does not replace text typed by user Fix text replacement for completion
2 participants