Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing feature uniqueness diagnostic issue for renamed features #305

Merged
merged 4 commits into from
Oct 7, 2024
Merged

fixing feature uniqueness diagnostic issue for renamed features #305

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85d35a8
fixing feature uniqueness diagnostic issue for renamed features
arunvenmany-ibm Sep 30, 2024
1dbf0cb
fixing feature uniqueness diagnostic issue for renamed features- incr…
arunvenmany-ibm Oct 1, 2024
dd67386
fixing diagnostic message case issues
arunvenmany-ibm Oct 1, 2024
912230e
changing log location as per review comments
arunvenmany-ibm Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lemminx-liberty/src/test/java/io/openliberty/LibertyDiagnosticTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,22 @@ public void testUniquenessForNameChangedFeatureDiagnostic() throws BadLocationEx
XMLAssert.testDiagnosticsFor(serverXML, null, null, serverXMLURI,
invalid);

serverXML = String.join(newLine, //
"<server description=\"Sample Liberty server\">", //
" <featureManager>", //
" <platform>javaee-7.0</platform>", //
" <feature>enterpriseBeans-4.0</feature>", //
" <feature>ejb-3.2</feature>", //
" </featureManager>", //

"</server>" //
);
invalid = new Diagnostic();
invalid.setRange(r(4, 24, 4, 31));
invalid.setMessage("ERROR: The ejb-3.2 feature cannot be configured with the enterprisebeans-4.0 feature because they are two different versions of the same feature. The feature name changed from ejb to enterprisebeans for Jakarta EE. Remove one of the features.");
cherylking marked this conversation as resolved.
Show resolved Hide resolved
XMLAssert.testDiagnosticsFor(serverXML, null, null, serverXMLURI,
invalid);

serverXML = String.join(newLine, //
"<server description=\"Sample Liberty server\">", //
" <featureManager>", //
Expand Down
Loading