Sast issue fix 1.0 #294
Merged
Sast issue fix 1.0 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arunvenmany-ibm
commented
Aug 7, 2024
•
arunvenmany-ibm
commented
- modified try with resources to normal try as try with resources with xml reader shows xml injection error
- refactored code, moved XmlEventReader code to a separate private method
- Added private static method where factory.createXMLEventReader is called
- Added exception handler to return custom message in DocumentUtils#transformer.transform
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
… lemminx Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
… lemminx Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
… lemminx Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
requested changes
Aug 7, 2024
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/XmlReader.java
Show resolved
Hide resolved
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/DocumentUtil.java
Show resolved
Hide resolved
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/XmlReader.java
Show resolved
Hide resolved
liberty-ls/src/main/java/io/openliberty/tools/langserver/utils/XmlReader.java
Show resolved
Hide resolved
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
requested changes
Aug 7, 2024
lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/util/XmlReader.java
Show resolved
Hide resolved
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.