-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostics and Quick fixes for lost config elements #220
Conversation
...nx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/AddFeature.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment about the FeatureListGraph in FeatureService is significant and requires some code changes. Hopefully it's doable.
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...x-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/services/FeatureService.java
Outdated
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...x-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/services/FeatureService.java
Outdated
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...nx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/AddFeature.java
Outdated
Show resolved
Hide resolved
...nx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/AddFeature.java
Outdated
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Show resolved
Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java
Outdated
Show resolved
Hide resolved
...nx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/AddFeature.java
Outdated
Show resolved
Hide resolved
...nx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/AddFeature.java
Outdated
Show resolved
Hide resolved
...x-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/services/FeatureService.java
Show resolved
Hide resolved
...liberty/src/main/java/io/openliberty/tools/langserver/lemminx/services/LibertyWorkspace.java
Show resolved
Hide resolved
...nx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/AddFeature.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See one comment about LOGGER variable.
* Add FeatureListGraph, FeatureListNode, AddFeature * Use new surefire with junit 5 support, skip tests in build step GHA * reduce feature request delay 120 -> 10
Addresses #67
CodeActionParticipant, AddFeature:
DiagnosticParticipant:
server.xml
to recognize config elements.New FeatureListGraph class:
New FeatureListNode class:
.
isn't typical in a normal element name.FeatureService:
Tests: