Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure input stream is closed for properties files #217

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Ensure input stream is closed for properties files #217

merged 1 commit into from
Oct 4, 2023

Conversation

cherylking
Copy link
Member

Fixes #216

@cherylking cherylking requested a review from scottkurz October 4, 2023 19:29
scottkurz
scottkurz approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@scottkurz scottkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cherylking cherylking merged commit 2522cb6 into OpenLiberty:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottkurz scottkurz scottkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LCLS locks openliberty.properties preventing mvn clean when server.xml open in editor
2 participants
@cherylking @scottkurz