Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow feature completion list and provide quick fix for invalid feature #214

Merged
merged 7 commits into from
Sep 11, 2023

Conversation

cherylking
Copy link
Member

Related to #180

@cherylking
Copy link
Member Author

This is what the quick fix looks like:

Screenshot 2023-09-08 at 1 39 25 PM

Screenshot 2023-09-08 at 1 39 10 PM

Copy link
Contributor

@dshimo dshimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be merged into main as a completion list fix or 4q2023 with the addition of a new quick fix feature? Looks good to me either way.

@cherylking
Copy link
Member Author

Would this be merged into main as a completion list fix or 4q2023 with the addition of a new quick fix feature? Looks good to me either way.

@dshimo Good point. Originally I was just trying to fix the completion list. But this is more of an enhancement that should probably be targeted to 4q2023. Is it easy to change the PR to target a different branch? Or do I need to close this one and open a new one?

@evie-lau evie-lau changed the base branch from main to 4q2023 September 11, 2023 15:38
@dshimo
Copy link
Contributor

dshimo commented Sep 11, 2023

@cherylking Seems like you got it. We're good to merge

@cherylking cherylking merged commit 231e004 into OpenLiberty:4q2023 Sep 11, 2023
dshimo pushed a commit that referenced this pull request Oct 10, 2023
…ure (#214)

* Prep for 2.0.1 release (#211)

* [maven-release-plugin] prepare release lemminx-liberty-2.0.1

* [maven-release-plugin] prepare for next development iteration

* [maven-release-plugin] prepare release liberty-langserver-2.0.1

* [maven-release-plugin] prepare for next development iteration

* Narrow feature completion list and provide quick fix for invalid feature

---------

Co-authored-by: wasdevb1@us.ibm.com <wasdevb1@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants