Fix determination of Liberty Workspace for non-default server.xml #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherylking
force-pushed
the
determineLibertyWorkspaceCorrectly
branch
2 times, most recently
from
c6ae3f4 to
6e35a4a
Compare
cherylking
force-pushed
the
determineLibertyWorkspaceCorrectly
branch
from
6e35a4a to
5c38464
Compare
|
@dshimo For the helper methods in LibertyUtils, if there is more concise syntax for the places I am iterating through collections to check for matches, please add review comments and I will update. TIA |
dshimo
approved these changes
Aug 23, 2023
cherylking
force-pushed
the
determineLibertyWorkspaceCorrectly
branch
from
b25691e to
cf9b923
Compare
dshimo
pushed a commit
that referenced
this pull request
Aug 25, 2023
* Fix determination of Liberty Workspace for non-default server.xml * Clean up
dshimo
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Fix determination of Liberty Workspace for non-default server.xml * Clean up
dshimo
added a commit
that referenced
this pull request
Aug 31, 2023
* Fix determination of Liberty Workspace for non-default server.xml * Clean up
evie-lau
pushed a commit
to evie-lau/liberty-language-server
that referenced
this pull request
Sep 1, 2023
…enLiberty#201) * Fix determination of Liberty Workspace for non-default server.xml * Clean up
dshimo
added a commit
that referenced
this pull request
Oct 10, 2023
* Fix determination of Liberty Workspace for non-default server.xml * Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200
Please note that I changed the yaml to build/test the
4q2023branch since this PR is for that branch.