-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address ID review items #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evelinec @realModusOperandi I made just a few small suggestions. Let me know if you have any questions. Thanks!
README.adoc
Outdated
the entire application. A good service performs only one function and does it well. In | ||
this case, `ArtistsService` will handle requesting artists data from the REST | ||
service. | ||
entire applications. A good service performs only one function and it performs this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change
"A good service performs only one function and it performs this function well."
to
"A good service performs only one function, and it performs this function well."
README.adoc
Outdated
must be converted to a Promise using [hotspot=httpInstanceAndAwaitFeatureAndHttpGetAndToPromise]`toPromise()`. A Promise is how | ||
JavaScript represents the state of an asynchronous operation. If you want to learn | ||
more, check out https://promisejs.org[^] for an introduction. | ||
Create the entire [hotspot=artistsServiceClass]`ArtistsService` class with the [hotspot=atInjectable]`@Injectable` annotation. Add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check to make sure there isn't an extra space between "the" and "[hotspot=atInjectable]@Injectable
"
README.adoc
Outdated
[hotspot=importHttpClient]`HttpClient` and [hotspot=importInjectable]`Injectable` | ||
import statements at the top. | ||
|
||
The file imports the [hotspot=importHttpClient]`HttpClient` class and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change
"The file imports the [hotspot=importHttpClient]HttpClient
class and
[hotspot=importInjectable]Injectable
decorator."
to
"The file imports the [hotspot=importHttpClient]HttpClient
class and the [hotspot=importInjectable]Injectable
decorator."
the result of the | ||
[hotspot=httpInstanceAndAwaitFeatureAndHttpGetAndToPromise]`HttpClient.get()` method to | ||
be compatible with this feature, it must be converted to a Promise invoking its | ||
[hotspot=httpInstanceAndAwaitFeatureAndHttpGetAndToPromise]`toPromise()` method. A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change
"For the result of the [hotspot=httpInstanceAndAwaitFeatureAndHttpGetAndToPromise]HttpClient.get()
method to be compatible with this feature, it must be converted to a Promise invoking its [hotspot=httpInstanceAndAwaitFeatureAndHttpGetAndToPromise]toPromise()
method."
to
"For the result of the [hotspot=httpInstanceAndAwaitFeatureAndHttpGetAndToPromise]HttpClient.get()
method to be compatible with this feature, it must be converted to a Promise by invoking its [hotspot=httpInstanceAndAwaitFeatureAndHttpGetAndToPromise]toPromise()
method."
component so the component can run code in response to this event. This component | ||
responds to the [hotspot=onInitInterface]`OnInit` event via the | ||
[hotspot=ngOnInitMethod]`ngOnInit` method which fetches and populates the component's | ||
template with data when it is initialized for display. The file imports the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change
"This component responds to the [hotspot=onInitInterface]OnInit
event via the [hotspot=ngOnInitMethod]ngOnInit
method which fetches and populates the component's template with data when it is initialized for display."
to
"This component responds to the [hotspot=onInitInterface]OnInit
event via the [hotspot=ngOnInitMethod]ngOnInit
method, which fetches and populates the component's template with data when it is initialized for display."
Ok, made the requested changes (and reformatted a line I missed.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@realModusOperandi Looks good. Thanks, Liam. Approved from an ID perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will refresh the staging site to proceed with the final testing.
Addressing comments in #27.
HttpClient.get()
call is what needs to be made compatible by invokingtoPromise()
on it, so I revised to say that.Yes these are correct.
div
is an element.*ngFor
is a directive:I've updated to use those terms in the format you requested.