Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted hotspot line numbers to tags #23

Merged
merged 4 commits into from
Jun 13, 2019
Merged

Converted hotspot line numbers to tags #23

merged 4 commits into from
Jun 13, 2019

Conversation

evelinec
Copy link
Contributor

@evelinec evelinec commented Jun 12, 2019 •
edited
Loading

Some feedback on hotspot tags:

  • The files that are tagged in the finish directory look very clouded with all the tags
  • May need a convention for tag names
  • Have some updates for the relevant doc

@evelinec
Copy link
Contributor Author

evelinec commented Jun 12, 2019 •
edited
Loading

The converted content is viewable on the lgdev staging site with the 4020 port. @gkwan-ibm @justineechen

@evelinec
Copy link
Contributor Author

@realModusOperandi would you like to take a look at the tag names in case you have some suggestions? Thank you.

@evelinec evelinec mentioned this pull request Jun 12, 2019
Closed
realModusOperandi
realModusOperandi approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@realModusOperandi realModusOperandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tag names look good to me

@evelinec evelinec merged commit b7f759a into dev Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkwan-ibm gkwan-ibm gkwan-ibm approved these changes

@realModusOperandi realModusOperandi realModusOperandi approved these changes

@justineechen justineechen Awaiting requested review from justineechen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evelinec @realModusOperandi @gkwan-ibm