Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates from review of README #21

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Updates from review of README #21

merged 1 commit into from
Jun 11, 2019

Conversation

realModusOperandi
Copy link
Contributor

Addressing various comments:

  • Updated hotspots referring to entire classes to exclude annotations applied to the class itself as per standard.
  • Fixed AppComponent hotspot near line 186 to highlight the entire class
  • Added a note that ARTISTS_URL can point to any API endpoint on the internet if a full URL is specified.
  • Improved the wording of the description of fetchArtists()
  • Added a short definition of Promise and a link to the official explanation
  • Added a missing hotspot for AppComponent
  • Fixed the variable name when discussing the *ngFor

@realModusOperandi realModusOperandi self-assigned this Jun 10, 2019
evelinec
evelinec approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@evelinec evelinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge to refresh on staging site to review.

@evelinec evelinec merged commit 2dc4593 into OpenLiberty:dev Jun 11, 2019
@evelinec evelinec mentioned this pull request Jun 11, 2019
Closed
@realModusOperandi realModusOperandi deleted the round-6 branch June 11, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evelinec evelinec evelinec approved these changes

Assignees

@realModusOperandi realModusOperandi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realModusOperandi @evelinec