Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round 4 of feedback #12

Merged
merged 1 commit into from
May 13, 2019
Merged

Round 4 of feedback #12

merged 1 commit into from
May 13, 2019

Conversation

realModusOperandi
Copy link
Contributor

@realModusOperandi realModusOperandi commented May 13, 2019 •
edited
Loading

  • Updated page-seo-title and page-seo-description as suggested.
  • Applied Acrolinks suggestions.
  • Updated build artifact id to io.openliberty.guides.consumingrest-ng in both pom.xml and server.xml across both start and finish.
  • Removed comments in pom (I left one that might help users who want to add other npm commands to their pom)
  • Applied one more tslint suggestion to declare a variable as const since it isn't modified. I don't think there is any guide text that needs to be updated for this change.

Tested that both start and finish folders build and run properly in a fresh clone of the branch.

@realModusOperandi realModusOperandi mentioned this pull request May 13, 2019
Closed
8 tasks
@evelinec evelinec self-requested a review May 13, 2019 14:30
evelinec
evelinec approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@evelinec evelinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Thank you.

@evelinec evelinec merged commit 3dbd4bb into OpenLiberty:dev May 13, 2019
@realModusOperandi realModusOperandi deleted the round-4 branch May 23, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evelinec evelinec evelinec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realModusOperandi @evelinec