Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test cases to close input streams #1750

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix test cases to close input streams #1750

merged 1 commit into from
Oct 31, 2023

Conversation

cherylking
Copy link
Member

No description provided.

@cherylking cherylking requested a review from evie-lau October 31, 2023 14:53
evie-lau
evie-lau approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@evie-lau evie-lau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worthwhile to create an Abstract class with the method logContainsMessage() for our test classes to extend and use?

@cherylking
Copy link
Member Author

Would it be worthwhile to create an Abstract class with the method logContainsMessage() for our test classes to extend and use?

Yes. We can look into doing that in a future PR.

@cherylking cherylking merged commit e89bd0b into OpenLiberty:main Oct 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evie-lau evie-lau evie-lau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cherylking @evie-lau