OLMIS-7953 Copied solution with multiple program ids to make application logging performance better. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAM-218: Many program ids for GET API for orderables. (#109) * OAM-218: WIP * OAM-218: Change programId param to repeatable * OAM-218: Changed getting all orderables to get for many program codes. * OAM-213: Added fixes. * OAM-213: Changed to have multiple "program" API parameter. * OAM-213: Corrected tests. * OAM-213: Corrected some tests and added some constants. * OAM-213: Applied some corrections. * OAM-218: Name corrected. * OAM-218: Fix for tests. * OAM-218: Fix for test. * OAM-218: Fix for repository tests (by pwargulak). * OAM-218: Fixes after review. --------- Co-authored-by: Piotr Wargulak <pwargulak@soldevelo.com> Co-authored-by: Szymon Radziszewski <sradziszewski@soldevelo.com>
mgrochalskisoldevelo
approved these changes
Jul 9, 2024
src/main/java/org/openlmis/referencedata/repository/custom/impl/OrderableRepositoryImpl.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution is about adding the ability to use multiple program ids in the request to /api/orderables.
Cherry-pick (modified) from OAM-218 solution, commit 794d23f.
OAM-218: Many program ids for GET API for orderables. (#109)
OAM-218: WIP
OAM-218: Change programId param to repeatable
OAM-218: Changed getting all orderables to get for many program codes.
OAM-213: Added fixes.
OAM-213: Changed to have multiple "program" API parameter.
OAM-213: Corrected tests.
OAM-213: Corrected some tests and added some constants.
OAM-213: Applied some corrections.
OAM-218: Name corrected.
OAM-218: Fix for tests.
OAM-218: Fix for test.
OAM-218: Fix for repository tests (by pwargulak).
OAM-218: Fixes after review.