Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cv headers soname #611

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Cv headers soname #611

merged 2 commits into from
Mar 3, 2020

Conversation

kwizart
Copy link
Contributor

@kwizart kwizart commented Feb 28, 2020

Here are two patches used by the fedora package.

Fix opencv headers compatible with opencv2+ including OpenCV4 that has dropped support for opencv/cv.h

There is also an issue with the SONAME that integrate the micro version whereas the ABI is compatible with the previous libfreenect 0.5.0. So keep using libfreenect.so.0 instead.

opencv/cv.h is removed on opencv4

Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>
This will change SONAME to libfreenect.so.0 instead of 0.6

Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>
@piedar
Copy link
Contributor

piedar commented Mar 2, 2020

Nice! I think it would be ideal to have both versions as symlinks, like libfreenect.so -> libfreenect.so.0 -> libfreenect.so.0.6 -> libfreenect.so.0.6.0 but I don't see how to do that with cmake. If you know a better way please advise - otherwise I'll go ahead and merge this.

@piedar piedar added this to the v0.6.1 milestone Mar 2, 2020
@kwizart
Copy link
Contributor Author

kwizart commented Mar 2, 2020

The symlinks are only useful for the unversioned .so to allow the linker to find the appropriate library at link time. It will detect the internal name of the library (SONAME) that also need to have a symlink or it will be created by the system linker at library registration anyway (ldconfig).

Others symlinks are not useful to anything and additional symlinks are usually not done across projects (looking at /usr/lib64/)

@piedar piedar merged commit 7398a41 into OpenKinect:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants