Increase unsorted maximum network list length to 200, sorted length t…

…o 75 In 2021, it is fairly easy to have more than 100 unique BSSIDs in cities
OpenIntelWireless · Mar 15, 2021 · 51e0af5 · 51e0af5
1 parent 5f3c9a6
commit 51e0af5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/ClientKit/Api.h b/ClientKit/Api.h
@@ -23,7 +23,7 @@
 #include <stdlib.h>
 #include <string.h>
 
-#define MAX_NETWORK_LIST_LENGTH 50
+#define MAX_NETWORK_LIST_LENGTH 200
 #define MAX_SSID_LENGTH 32
 
 typedef struct {

diff --git a/HeliPort/Appearance/StatusMenu.swift b/HeliPort/Appearance/StatusMenu.swift
@@ -182,7 +182,8 @@ final class StatusMenu: NSMenu, NSMenuDelegate {
     private let hardwareInfoSeparator = NSMenuItem.separator()
 
     private var networkItemList = [NSMenuItem]()
-    private let maxNetworkListLength = MAX_NETWORK_LIST_LENGTH
+                                          // 200 will cause serious lag when scrolling
+    private let maxNetworkListLength = 75 // MAX_NETWORK_LIST_LENGTH
     private let networkItemListSeparator: NSMenuItem = {
         let networkItemListSeparator =  NSMenuItem.separator()
         networkItemListSeparator.isHidden = true
@@ -572,6 +573,9 @@ final class StatusMenu: NSMenu, NSMenuDelegate {
         NetworkManager.scanNetwork { networkList in
             self.isNetworkListEmpty = networkList.count == 0 && !self.isNetworkConnected
             var networkList = networkList
+            if networkList.count > self.networkItemList.count {
+                Log.error("Number of scanned networks (\(networkList.count)) exceeds maximum (\(self.networkItemList.count))")
+            }
             for index in 1 ..< self.networkItemList.count {
                 if let view = self.networkItemList[index].view as? WifiMenuItemView {
                     if networkList.count > 0 {