Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build issue #20

Merged
merged 7 commits into from
Sep 18, 2023

Conversation

maximthomas
Copy link
Contributor

fix build issue #19, rename artifacts to opendientiyplatform and remove OpenAM submodule

@lscorcia
Copy link
Contributor

lscorcia commented Sep 14, 2023

Would it be possible to build with Java 11? I tried with your PR and it seems to fail with "version 1.5 no longer supported" in project jee-agents-sdk . It works with Java 8.

Thank you!

EDIT: It is enough to just add those two lines to the main pom.xml:

<properties>
  ...
  <maven.compiler.source>1.8</maven.compiler.source>
  <maven.compiler.target>1.8</maven.compiler.target>
</properties>

The build then works on Java11 too.

@lscorcia
Copy link
Contributor

lscorcia commented Sep 14, 2023

Additional comment - the newly generated package does not contain the necessary dependencies, so it does not install:

  • agent.jar
  • commons-io-.jar
  • openam-installtools-.jar
  • openam-installtools-launcher-.jar
  • openssoclientsdk.jar

EDIT: The issue is caused by jee-agents-distribution/jee-agents-distribution-tomcat-v6/src/main/assembly/tomcat-v6_KitAssembly_Descriptor.xml - it still uses org.forgerock.openam instead of org.openidentityplatform.openam.

@lscorcia
Copy link
Contributor

Unfortunately even that isn't enough. Now it installs correctly, but it errors at startup. Missing/moved dependency?

14-Sep-2023 17:30:40.080 SEVERE [main] org.apache.tomcat.util.digester.Digester.startElement Begin event threw exception
java.lang.NoClassDefFoundError: org/forgerock/openam/sdk/org/forgerock/util/time/TimeService
at org.forgerock.openam.utils.Time.(Time.java:48)
at org.forgerock.openam.utils.Time.(Time.java:43)
at com.iplanet.am.util.SystemProperties$PropertiesHolder.(SystemProperties.java:751)
at com.iplanet.am.util.SystemProperties.(SystemProperties.java:135)
at com.sun.identity.agents.arch.AgentConfiguration.bootStrapClientConfiguration(AgentConfiguration.java:708)
at com.sun.identity.agents.arch.AgentConfiguration.initializeConfiguration(AgentConfiguration.java:1147)
at com.sun.identity.agents.arch.AgentConfiguration.(AgentConfiguration.java:1586)
at com.sun.identity.agents.arch.Manager.(Manager.java:675)
at com.sun.identity.agents.tomcat.v6.AmTomcatRealm.(AmTomcatRealm.java:67)

@maximthomas
Copy link
Contributor Author

@lscorcia hi, you can check the latest commit in the PR

@vharseko vharseko merged commit 4fd8166 into OpenIdentityPlatform:master Sep 18, 2023
@maximthomas maximthomas deleted the issues/fix-build-19 branch September 18, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants