throw an IAE on a missing class alias #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryShea
reviewed
Aug 30, 2023
| @@ -66,6 +66,8 @@ public class TextWire extends YamlWireOut<TextWire> { | |||
| static final Supplier<StopCharsTester> STRICT_END_OF_TEXT_ESCAPING = TextStopCharsTesters.STRICT_END_OF_TEXT::escaping; | |||
| static final Supplier<StopCharsTester> END_EVENT_NAME_ESCAPING = TextStopCharsTesters.END_EVENT_NAME::escaping; | |||
| static final Bytes<?> META_DATA = Bytes.from("!!meta-data"); | |||
| @Deprecated(/* for removal in x.26, make default true in x.25 */) | |||
| static final boolean IAE_ON_CNF = Jvm.getBoolean("illegal.argument.for.missing.class.alias", false); | |||
There was a problem hiding this comment.
@chroniclekevinpowe given that this will not change behaviour unless someone turns on the system property, I think that this is a candidate for backporting to 23
There was a problem hiding this comment.
It should be possible to backport even breaking changes with this strategy of having it disabled by default.
|
SonarCloud Quality Gate failed.
|
chroniclekevinpowe
pushed a commit
that referenced
this pull request
Sep 1, 2023
* throw an IAE on a missing class alias * Change how banned package are handled
chroniclekevinpowe
added a commit
that referenced
this pull request
Sep 1, 2023
Backport throw an IAE on a missing class alias (#721) to 2.23
peter-lawrey
added a commit
that referenced
this pull request
Sep 5, 2023
* throw an IAE on a missing class alias * Change how banned package are handled
peter-lawrey
added a commit
that referenced
this pull request
Jan 5, 2024
* throw an IAE on a missing class alias * Change how banned package are handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.