Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep resetting causes segfaults for some classes #745

Closed
nicktindall opened this issue Oct 19, 2023 · 2 comments
Closed

Deep resetting causes segfaults for some classes #745

nicktindall opened this issue Oct 19, 2023 · 2 comments

Comments

@nicktindall
Copy link
Contributor

The new deep resetting feature traverses in to all objects and attempts to set their fields back to the "default" values. This doesn't play nice with (at least) LocalDate.
nicktindall added a commit that referenced this issue Oct 19, 2023
@nicktindall
Tactical fix to temporarily allow EFX to build #745
8651786
nicktindall added a commit that referenced this issue Oct 19, 2023
@nicktindall
Reproduce segfault from EFX build. Reproduces #745
37cfb55
nicktindall added a commit that referenced this issue Oct 19, 2023
@nicktindall
Reproduce segfault from EFX build. Reproduces #745
c83842e
nicktindall added a commit that referenced this issue Oct 19, 2023
@nicktindall
Tactical fix to temporarily allow EFX to build #745
f0f6907
nicktindall added a commit that referenced this issue Oct 19, 2023
@nicktindall
Reproduce segfault from EFX build. Reproduces #745
2dea048
nicktindall added a commit that referenced this issue Oct 19, 2023
@nicktindall
Tactical fix to temporarily allow EFX to build #745
97be542
nicktindall added a commit that referenced this issue Oct 19, 2023
@nicktindall
Disable deep resetting for object fields #745
e6f2281
nicktindall added a commit that referenced this issue Oct 19, 2023
@nicktindall
Disable deep resetting for object fields #745
55b782b
nicktindall added a commit that referenced this issue Oct 19, 2023
@nicktindall
Disable deep resetting for object fields #745
96bcb58
@alamar
Copy link
Contributor

alamar commented Oct 19, 2023

I don't believe we should be resetting any objects which are not collections or Marshallables/SelfDescribingMarshallables with reset()

alamar added a commit that referenced this issue Oct 19, 2023
@alamar
Revert "Disable deep resetting for object fields #745"
a20806b 
This reverts commit 96bcb58.
alamar added a commit that referenced this issue Oct 19, 2023
@alamar
Revert "Disable deep resetting for object fields #745"
399fe56 
This reverts commit 96bcb58.
alamar added a commit that referenced this issue Oct 30, 2023
@alamar
Only deep reset if default object is of the same type as current and …
cb3bf80 
…is not null

Change API to remove redundant defaults param
Revert "Disable deep resetting for object fields #745"
This reverts commit 96bcb58.
alamar added a commit that referenced this issue Nov 14, 2023
@alamar
Only deep reset if default object is of the same type as current and …
47234b0 
…is not null

Change API to remove redundant defaults param
Improve README around reset()
Revert "Disable deep resetting for object fields #745"
This reverts commit 96bcb58.
@hft-team-city
Copy link
Collaborator

Released in Chronicle-Wire-2.25ea1, BOM-2.25ea1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alamar @nicktindall @hft-team-city