remove SMPP adaptor #942
Merged
remove SMPP adaptor #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josephjclark whats the process for removing adaptors ? |
|
@mtuchi yeah exactly that. Delete it from the repo and deprecate on npm |
josephjclark
approved these changes
Jan 27, 2025
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all. I think that this adaptor is for working with the old OpenFn v1 SMPP Client. There was this crazy Erlang SMPP client implementation we did back in the day to support some work in Guatemala. It's no longer around. Is this a generic SMPP adaptor that would work with lots of different SMPP APIs? Or is it something that was specific to an OpenFn implementation, making our SMPP client accessible via REST API?
(I think the latter.)