-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghana Adaptors for Wigal SMS, NIA and BDR #938
base: epic/ghana
Are you sure you want to change the base?
Conversation
Hiya @stevkky I have cleanup the Here is the list of the improvements i have made and i want you to apply those for the bdr and nia adaptor
Here is what i need you to do for BDR & NIA adaptor
|
* @returns {Operation} | ||
* @state {HttpState} | ||
*/ | ||
export function sendBirthNotification(data, options = {}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevkky do you know if the API has options like query params ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't think it does, no. (also no public docs, so we should release this as version 0.1.0
and see how it goes... all bets are off until we hit 1.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy with all of these as v0.1.0
adaptors. let get them used and tested in the workshop this week and see what changes we want later.
Summary
I have added the adaptors for Wigal SMS, NIA and BDR
Details
The Wigal SMS adaptor have been tested against the live API to send messages successfully.
The Birth and Death Registry (BDR) and National Identification Authority (NIA) are yet to be tested.
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.