-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeignMetricTagResolver lost Exception tag #1716
Comments
eshishkin
added a commit
to eshishkin/feign
that referenced
this issue
Aug 9, 2022
Hi, I met the same issue in our project a couple of days ago. I created a PR (#1720), so it should solve the problem |
velo
pushed a commit
that referenced
this issue
Aug 9, 2022
velo
pushed a commit
that referenced
this issue
Oct 7, 2024
velo
pushed a commit
that referenced
this issue
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when call the method "feign.micrometer.FeignMetricTagResolver#tag(feign.MethodMetadata, feign.Target<?>, java.lang.Throwable, io.micrometer.core.instrument.Tag...)" as below, the "e" was lost as not pass to the inner method
public Tags tag(MethodMetadata methodMetadata, Target<?> target, Throwable e, Tag... tags) {
return tag(methodMetadata.targetType(), methodMetadata.method(), target.url(), tags);
}
The text was updated successfully, but these errors were encountered: