Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Support custom tags for Micrometer #1456

Closed
fdw opened this issue Jul 11, 2021 · 4 comments · Fixed by #2305
Closed

[Feature Request] Support custom tags for Micrometer #1456

fdw opened this issue Jul 11, 2021 · 4 comments · Fixed by #2305
Assignees
@BartekBanachowicz
Labels
enhancement For recommending new capabilities

Comments

@fdw
Copy link

fdw commented Jul 11, 2021

If I add .addCapability(new MicrometerCapability(meterRegistry)) to my Feign client, there seems to be no way to add custom tags to the Micrometer metrics. It would be nice to do this, for example by extending MicrometerCapability to MicrometerCapability(meterRegistry, mapOfTags()).
@kdavisk6 kdavisk6 added the enhancement For recommending new capabilities label Jul 19, 2021
@tzifudzi
Copy link

+1

@r1jsheth
Copy link

r1jsheth commented Jan 7, 2023

I would also love to have this feature.
@kdavisk6 do you think this can be a good first issue?
I can work on it.

@BartekBanachowicz
Copy link
Contributor

Hey, @kdavisk6 and @velo, I'd love to work on this. Could you assign this issue to me?

@kdavisk6
Copy link
Member

You don't need our permission, just go ahead and submit a PR when you are ready 👍🏻

BartekBanachowicz added a commit to BartekBanachowicz/feign that referenced this issue Jan 24, 2024
@BartekBanachowicz
OpenFeign#1456 | Add custom tags to MicrometerCapability
47593b7
@BartekBanachowicz BartekBanachowicz mentioned this issue Jan 24, 2024
Merged
velo added a commit that referenced this issue Jan 25, 2024
@BartekBanachowicz @velo
Add custom tags to MicrometerCapability (#2305)
1e03ac3 
* #1456 | Add custom tags to MicrometerCapability

* Update MicrometerCapability.java license year

---------

Co-authored-by: Marvin <velo@users.noreply.github.com>
velo added a commit that referenced this issue Oct 7, 2024
@BartekBanachowicz @velo
Add custom tags to MicrometerCapability (#2305)
9507881 
* #1456 | Add custom tags to MicrometerCapability

* Update MicrometerCapability.java license year

---------

Co-authored-by: Marvin <velo@users.noreply.github.com>
velo added a commit that referenced this issue Oct 8, 2024
@BartekBanachowicz @velo
Add custom tags to MicrometerCapability (#2305)
5127db7 
* #1456 | Add custom tags to MicrometerCapability

* Update MicrometerCapability.java license year

---------

Co-authored-by: Marvin <velo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BartekBanachowicz BartekBanachowicz

Labels
enhancement For recommending new capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add custom tags to MicrometerCapability BartekBanachowicz/feign
5 participants
@fdw @kdavisk6 @tzifudzi @r1jsheth @BartekBanachowicz