Skip to content

Commit

Permalink
Improve Documentation for feign-metrics (#2463)
Browse files Browse the repository at this point in the history
**Problem**

From the current documentation it is not immediately  clear that additional dependencies are needed to make feign metrics work. This can lead to frustration.

**Solution**

Explicitly mention that additional dependencies are needed to make feign-metrics work.
  • Loading branch information
si-net authored Jun 28, 2024
1 parent 37e48e6 commit b207b51
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1123,6 +1123,10 @@ But, it's possible to add metric collection capabilities to any feign client.
Metric Capabilities provide a first-class Metrics API that users can tap into to gain insight into the request/response lifecycle.
> **A Note on Metrics modules**:
>
> All the metric-integrations are built in separate modules and not available in the `feign-core` module. You will need to add them to your dependencies.
#### Dropwizard Metrics 4
```
Expand Down

0 comments on commit b207b51

Please sign in to comment.