Update InflowWind_c_bindings interface #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add debuglevel (only partially completed) - update regression test - remove the passing of the uniform wind file (might be able to remove some stuff from IfW) - other updates to more closely match structure of ADI_c - some linting
andrew-platt
force-pushed
the
f/IfW_C_mods_coupling
branch
3 times, most recently
from
fd9d46f to
46c4cbd
Compare
andrew-platt
force-pushed
the
f/IfW_C_mods_coupling
branch
from
46c4cbd to
24e2e50
Compare
deslaughter
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
The IfW_C_bindings interface was difficult to use with external codes. One feature it had was the ability to pass the
Uniformfile type input file as a string. This added unnecessary complexity and wasn't actually used by anyone. A few other updates bring this module closer in line with how the ADI_c_bindings library is written.debuglevel(only partially completed)Related issue, if one exists
none
Impacted areas of the software
The InflowWind library interface only
Additional supporting information
Test results, if applicable
No results change, but the
py_ifw_turbsimffscript changes.