Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwtc lib: SetErrStat ref'd incorrectly in VTK #2223

Merged
merged 1 commit into from
May 16, 2024

Conversation

andrew-platt
Copy link
Collaborator

Ready to merge

Feature or improvement description
The SetErrStat was moved to NWTC_Base.f90 from NWTC_IO.f90. This was not updated in VTK.f90. Somehow GH actions and all the setups I was using for compiling did not error on this.

Related issue, if one exists
NA

Impacted areas of the software
Compilation on a few systems.

Additional supporting information
Thanks to @RyanDavies19 for finding this!

Copy link
Collaborator

@deslaughter deslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably worked because NWTC_IO uses SubSys which uses NWTC_Base which has SetErrStat. gfortran must have allowed it to be exposed up through the chain. Yet another unintended consequence of the tight coupling changes.

@deslaughter deslaughter merged commit 5cc9971 into OpenFAST:dev May 16, 2024
21 checks passed
@andrew-platt andrew-platt deleted the b/SetErrStat_in_NWTCio branch June 6, 2024 16:57
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants