ADI: probably memory leak in ADI_UpdateStates #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ADI_UpdateStates routine makes a copy of the AD_Input, but never destroyed that data after usage. This could lead to memory continously getting allocated during a simulation with either ADI_C_Binding or the AD driver.
andrew-platt
force-pushed
the
b/ADI_MemLeak
branch
from
b1c8782 to
96eb6b6
Compare
deslaughter
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Destroying the input at the end of ADI_UpdateStates gets rid of most of the memory leaks as checked with valgrind. The following needs to be added at line 760 of fVW.f90 to get rid of the other memory leaks: call FVW_DestroyInput(uInterp, ErrStat2, ErrMsg2); if(Failed()) return
Done! Thanks for checking this! |
deslaughter
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to merge.
Feature or improvement description
The ADI_UpdateStates routine makes a copy of the AD_Input, but never destroyed that data after usage. This could lead to memory continuously getting allocated during a simulation with either ADI_C_Binding or the AD driver.
Related issue, if one exists
This issue was reported by e-mail.
Impacted areas of the software
Additional supporting information
Test results, if applicable