TurbSim bug fix: fix index into Z array for text grid files #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused an index to be out of bounds if there were tower points
jjonkman
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
When requesting both tower points and text-formatted grid file outputs, an array could exceed the size of the array, causing an access violation.
Related issue, if one exists
This was reported on the NREL Forum: https://forums.nrel.gov/t/difference-between-fast-and-openfast-results/4665/29
Impacted areas of the software
TurbSim, only when both
WrADTWRandWrFMTFFare true (and probably only when the number of tower points is more than the number of horizontal grid points).Test results, if applicable
This doesn't get tested, so will not affect any results. Text-based full-field grid files are rarely used anywhere.