[BugFix] segfault with gfortran 10.4.0 -- NWTC_Base.f90 #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR OpenFAST#1538 introduced a seg-fault with some gfortran compilers. Added an #ifdef for the Flang compiler
deslaughter
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1538 introduced a seg-fault with some gfortran compilers. Added an #ifdef for the Flang compiler
Feature or improvement description
PR #1538 can cause segmentation faults with some compilers. I noticed this with gfotran 10.4.0: see #1538 (comment) for errors with gfortran 10.4.0 (Mac, Ventura 13.3, Intel) for a screenshot.
To remedy this I wrapped the changes to the
NWTC_Base.f90introduced in #1538 in an#ifdef.Related issue, if one exists
#1538 (comment)
#1538
Impacted areas of the software
Compiler only
Additional supporting information
Test results, if applicable