AeroDyn_Inflow minor updates #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in aerodyn_inflow_c) driver_types.f90
- use setVTKparameters from AeroDyn_Driver_Subs.f90 - Move data for simulation into SimData - remove now unused data structures
AD_Driver_Subs and _Types are used in the AD_Inflow_C_binding library, so reconfigured CMakeLists so it builds better.
Allocation of ADI types was occuring after usage
andrew-platt
force-pushed
the
f/ADIupdates
branch
from
e4bff87 to
dffd8e5
Compare
MHK pull request changed the arguments to this routine
This was resulting in weird issues with gcc 10.4 release. In release mode, this was cause the Wind1Vel[xyz] outputs from IfW to get to zero occasionally -- the regression tests would then fail.
ebranlard
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be merged immediately
Feature or improvement description
This PR includes minor revisions to AeroDyn_Inflow and AeroDyn_Inflow_C_bindings.
Related issue, if one exists
none
Impacted areas of the software
AeroDyn Driver and AeroDyn_Inflow_C_Bindings only
Additional supporting information
As part of coupling ADI to OWENS (from Sandia), I discovered a few minor things that warranted modification.
Test results, if applicable
No test results will change. The interface to ADI c-bindings changed slightly, so the
py_ad_5MW_OC4Semi_WSt_WavesWN AeroDynmodule test case changed.