[BugFix] CMake build on Windows and Ninja build on all platforms #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can see there is a small SubDyn fix in there, it's fine by me to keep it in this pull request |
I put that SD fix in this one as well: #1534 |
andrew-platt
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Feature or improvement description
This pull request fixes a recent bug which caused CMake projects generated on Windows to fail to build. It also fixes a long standing issue where Ninja builds generated by CMake (
-G Ninja) also failed to build. A minor change was to use CMake's FindPython to locate the Python interpreter. I larger change was to use CMake's FindLAPACK to locate the MKL and set the appropriate linker flags, which resolved the Windows build issue. The LAPACK/BLAS vendor can be specified when running CMake as explained at https://cmake.org/cmake/help/latest/module/FindBLAS.html#blas-lapack-vendors.Related issue, if one exists
#1523
Impacted areas of the software
/CMakeLists.txt/unit_tests/CMakeLists.txt/unit_tests/*/CMakeLists.txt/reg_tests/CTestList.cmake