Bugfixes for PR #1010 (CMake) #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _Types.f90 were collected in the wrong library. This was causing cmake + Visual studio to fail in building (VS treated the mapcpplib build as cpp only and ignored the .f90 files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for merging.
Description
There were a few minor issues with PR #1010. A couple of targets would not build directly including
nwtclibs_objandmaplib_obj. Themaplib_objandmapcpplib_objwere linking the wrong files. This has now been corrected.Related
This partially addresses #1523, but only for linux and mac (the Windows CMake is not addressed in this PR).
Impacted areas
The
CMakebuild systemTest results
None changed.