Updates to Allow Non-Uniform Force Point Distribution on Blades #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion into the newest OpenFAST.
Conflicts: modules/servodyn/src/UserSubs.f90
|
@andrew-platt @mchurchf the last commit here removes the changes that were only formatting. They were primarily additional white space that was automatically removed. I made this change so that we could see clearly the changes in the functionality. Since it's all in one commit, we can revert my commit after the review, if we'd like. |
added 3 commits
March 22, 2023 14:44
…t (we likely will have more than 2 options in the future)
rafmudaf
requested changes
Mar 22, 2023
rafmudaf
reviewed
May 8, 2023
andrew-platt
approved these changes
May 8, 2023
rafmudaf
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this is ready to be merged. The new feature is fully implemented, so it is ready in that way, but I don't know if it breaks tests. This should not affect tests unless there is a C++ interface test that now needs new input. I am not sure if I should call this "draft" or not. Andy/Raf, please get with me and we can determine.
Feature or improvement description
Worked with Ganesh to add a feature that allows for non-uniform force point distribution. The particular non-uniform spacing added here adds resolution based on decreasing chord size (i.e., more resolution near tips). This has been coded so that other options can be easily added later. This is an important feature because it reduces the actuator line point count requirements by a factor of 5-10 for high-resolution cases.
Related issue, if one exists
None
Impacted areas of the software
The C++ interface to CFD codes (i.e., the OpenFOAM interface).
Additional supporting information
The two figures below show the point distributions along an actuator line with the new capability. Both the velocity sampling points, which are defined through the Aerodyn blade point input (which is chord-clustered as computed in a preprocessing step outside OpenFAST), and the force-application points are shown. The new functionality from this PR allows the user to choose the old "uniform" force-application point distribution or the new "chord-clustered" distribution. These plots show that the new chord-clustered option gives results on top of our chord-clustered velocity sampling points computed with an outside Python code, so this works.
Test results, if applicable
N/A